Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Cumulus folder structure #278

Merged
merged 12 commits into from
Mar 28, 2018
Merged

Simplify Cumulus folder structure #278

merged 12 commits into from
Mar 28, 2018

Conversation

scisco
Copy link
Contributor

@scisco scisco commented Mar 27, 2018

  • remove the cumulus folder altogether
  • move cumulus/tasks to tasks folder at the root level
  • move the tasks that are not converted to use CMA to tasks/.not_CMA_compliant
  • update paths where necessary

CHANGELOG.md Outdated
@@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

### Updated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call this header either Changed or Fixed. There's no Updated section defined at https://keepachangelog.com/en/1.0.0/#how.

I would call it Changed if there's any chance at all something could be depending on the original directory structure, and would make that a major version bump.

Otherwise I would call it Fixed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Will update to "Changed". All the deployments should be using the tasks from npm so I don't expect anyone relying the folder structure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be listed under Fixed. This is only important because if there's a Changed section under Unreleased then that's an indicator that the next release needs to be a major version bump.

Copy link
Contributor

@kkelly51 kkelly51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the organization but also I'm scared.
yikes...
approved!

CHANGELOG.md Outdated
@@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

### Updated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be listed under Fixed. This is only important because if there's a Changed section under Unreleased then that's an indicator that the next release needs to be a major version bump.

@scisco
Copy link
Contributor Author

scisco commented Mar 28, 2018

@sethvincent fixed

@scisco scisco merged commit 578b942 into master Mar 28, 2018
@scisco scisco deleted the simplify_folder_structure branch March 28, 2018 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants