-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Cumulus folder structure #278
Conversation
CHANGELOG.md
Outdated
@@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
|
|||
## [Unreleased] | |||
|
|||
### Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would call this header either Changed
or Fixed
. There's no Updated
section defined at https://keepachangelog.com/en/1.0.0/#how.
I would call it Changed
if there's any chance at all something could be depending on the original directory structure, and would make that a major version bump.
Otherwise I would call it Fixed
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Will update to "Changed". All the deployments should be using the tasks from npm so I don't expect anyone relying the folder structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be listed under Fixed
. This is only important because if there's a Changed
section under Unreleased
then that's an indicator that the next release needs to be a major version bump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the organization but also I'm scared.
yikes...
approved!
CHANGELOG.md
Outdated
@@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
|
|||
## [Unreleased] | |||
|
|||
### Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be listed under Fixed
. This is only important because if there's a Changed
section under Unreleased
then that's an indicator that the next release needs to be a major version bump.
@sethvincent fixed |
cumulus
folder altogethercumulus/tasks
totasks
folder at the root leveltasks/.not_CMA_compliant